Miller begins his career with Celtic and is later loaned to the Danish sports club Aarhus Gymnastikforening in 2001. He returns to Celtic Park and breaks into the first-team squad during the 2003–04 season. Rejecting the offer of a new contract from Celtic, he joins Manchester United in 2004 on a free transfer under the Bosman ruling. Loaned to Leeds United during the 2005–06 season, he makes 22 first-team appearances for Manchester United.
Miller represents the Republic of Ireland team internationally, making his debut in 2004 against the Czech Republic. He earns 21 caps over the next five years, scoring one international goal.
On January 15, 2015, he joins League of IrelandCork City club, choosing his hometown club over several offers in Asia. He makes his debut on March 7 as the season begins with a 1–1 draw at Sligo Rovers. He is a regular in his only season at Turners Cross, in which the team finishes as runners-up in the league and the FAI Cup to Dundalk. On January 19, 2016, he chooses to leave the team.
A benefit football match is played on September 25, 2018, with the intention of raising funds for Miller’s family and charities. The Gaelic Athletic Association permits the game to be played at Páirc Uí Chaoimh in Cork, which would not normally be allowed under GAA rules. The match, between a Manchester United XI and a team composed of former Celtic and Republic of Ireland players, ends with the United XI winning on penalties following a 2–2 draw.
McCarthy makes his league debut for then-Fourth Division Barnsley on August 20, 1977, in a 4–0 win over Rochdale. He spends two years in the basement league, before the club wins promotion. A strong central defender, he is a virtual ever-present for his hometown club, but departs in December 1983 for fellow Division 2 club Manchester City.
Manchester City wins promotion in McCarthy’s first full season, and he finally has the chance to play at the highest level. His first season in the topflight is steady enough as the club reaches mid-table, but relegation strikes the following year. However, he does not face the drop as he signs for Celtic in May 1987 in a surprise £500,000 move.
McCarthy is brought to Parkhead by David Hay but within days of the signing the Celtic boss is sacked. Fortunately for McCarthy, Hay’s replacement is the returning Parkhead legend Billy McNeill, who quickly recognises that McCarthy’s strength and aggression are qualities desperately required by a notoriously leaky Celtic defence. He picks up his first silverware with Celtic as they win the league and cup double in his first season. The following season he again wins a Scottish Cup winners medal, although the club has to settle for third place in the league.
If ever an example is needed to reflect McCarthy’s values, it cannot be bettered than that on the day of the 1998 Scottish Cup Final. Celtic wins 2-1, but to the disgust of many, the unpopular ConservativePrime MinisterMargaret Thatcher is in attendance and to present the trophy to the winners. The players are under pressure from the Scottish Football Association (SFA) to meet her, but a few refuse. According to fellow Celtic player Andy Walker, McCarthy refuses point-blank, as he is from Barnsley and the son of a miner. Shaking hands with her is an impossibility for him.
In terms of his Celtic career, McCarthy never repeats the achievements or level of performance of his debut season.
McCarthy signs for Lyon in the summer of 1989 for £350,000. Afflicted by injuries and mindful of his spot in Ireland’s World Cup team, he finishes that season on loan to Millwall. After a captain’s showing in Italy for the Ireland national side, Millwall signs him full-time and later he becomes manager at The Den in 1992. In February 1996, he follows Jack Charlton into the Ireland manager’s job and experiences various highs and lows over his nearly seven years in charge. He has since managed Sunderland and Wolverhampton Wanderers.
In later years McCarthy becomes a low-key candidate for the Celtic manager’s job after the departures of Martin O’Neill and Gordon Strachan but is never favoured by the board or the general support for the role. Ironically then in 2018, he takes over from Martin O’Neill following his second stint as the Ireland manager. Notably, Roy Keane is Martin O’Neill’s assistant and has to step down also. On April 4, 2020, amid the global coronavirus pandemic, he stands down as manager and is immediately replaced by Stephen Kenny.
McCarthy joins Cypriot First Division club APOEL as manager on November 2, 2020, signing a contract until 2022. He is sacked by the club on January 5, 2021, following a run of 2 wins, 1 draw and 5 defeats in his eight games in charge.
On January 22, 2021, McCarthy is appointed as manager of Cardiff City, following the sacking of Neil Harris. He signs a contract until the end of the season. After making an unbeaten start to his reign at the club, a run that includes a six-game winning streak, he signs a new two-year deal with the club on March 4, 2021. Cardiff finishes the season in 8th place. Despite losing one of their opening six matches at the start of the following season, a run of results follows which sees Cardiff drop as low as 21st in the table. On October 23, 2021, after suffering a club-record eighth successive loss of the season at the hands of Middlesbrough, McCarthy leaves the club by mutual consent.
On January 19, 2023, McCarthy is appointed head coach of the Championship’s second-bottom placed club Blackpool on a short-term contract until the end of the season. On April 8, 2023, he leaves Blackpool by mutual consent, following a 3–1 home defeat to Cardiff the previous day. He achieves two wins in his 14 games in charge, losing nine of them, which leaves the club in 23rd position. “With results on the pitch not improving in recent weeks, the decision has been agreed by both parties that a change is needed,” the club says in a statement.
O’Neill becomes Republic of Ireland manager in 2013 and leads them to qualification for the 2016 UEFA European Football Championship for the third time in the nation’s history, beating the reigning world champions, Germany, in the process. He leaves the role with assistant Roy Keane by “mutual agreement” in November 2018. He is appointed as Nottingham Forest manager on January 15, 2019. He guides the club to a ninth-place finish in the Championship. However, he is sacked as manager on June 28, 2019, after reportedly falling out with some of the senior first team players.
In 2002, Norwich supporters voted O’Neill into the club’s Hall of Fame. He is awarded an OBE for services to sport in 2004. He is awarded the Nottingham Lifetime Achievement Award on November 3, 2013 for his services to football and achievements with Nottingham Forest.